From Japanese input, created file names become ".md"

[tkkuma-k]

I love this product, and need your help.
When I put [[something]] and click this with cmd, new file named "something.md" is created.
However when I put Japanese character in [[]], like [[新規]], and clicked this with cmd, the created file's name will be ".md".

[jevakallio]

Hi @tkkuma-k! Thanks for reporting this. This issue is being tracked in VSCode Markdown Notes that implements the new file feature:
kortina/vscode-markdown-notes#47

[digiguru]

I've added a potential fix downstream...

kortina/vscode-markdown-notes#53

But this will also need a fix in foam for the auto-generated links before this work in GitHub (but should work in vs code once merged)

[digiguru]

@tkkuma-k - would you be able to help making the test more authentic? I have written a test that checks as follows....

'Some Title' => 'some-title.md'
'Šömè Țítlê' => 'šömè-țítlê.md'

And I've used google translate to create a test for the Japanese language. Can you tell me an authentic way to say "Some title" in Japanese?

'タイトル' => 'タイトル.md'

Thanks

[tkkuma-k]

@digiguru
Thank you for your help!
'タイトル' is correct Japanese.

"Some title" in kanji character ...
'題目' => '題目.md'

and we often use the full-width alphabet and number.
'ｗｉｄｅ１２３'　=> 'ｗｉｄｅ１２３.md'

[digiguru]

Okay, my cultural assumptions have grown today, thankyou for enlightening me about Japanese Vs Kanji

I will add a test for full width alphabet, thanks!

[digiguru]

(done)

[digiguru]

Oh wait, what feels more correct here?

'Ｓｏｍｅ　Ｔｉｔｌｅ' => 'ｓｏｍｅ-ｔｉｔｌｅ'
or
'Ｓｏｍｅ　Ｔｉｔｌｅ' => 'ｓｏｍｅ－ｔｉｔｌｅ'

I'm guessing the second.

[tkkuma-k]

To me,
'Ｓｏｍｅ　Ｔｉｔｌｅ' => 'ｓｏｍｅ－ｔｉｔｌｅ'
feels like a more natural expression, but
'Ｓｏｍｅ　Ｔｉｔｌｅ' => 'ｓｏｍｅ-ｔｉｔｌｅ'
works , too.

[tkkuma-k]

Half-wide character, like ﾀｲﾄﾙ, was used in old documents and is still sometimes used in official documents, despite that it is discouraged.
Someone may use this. Because we can input this.
Please add this too.

'ﾀｲﾄﾙ' => 'ﾀｲﾄﾙ.md'

[digiguru]

Thankyou @tkkuma-k - I have checked and that works.

The full / half width of the slug will be a config option in
kortina/vscode-markdown-notes#53

so you can set it project wide depending on your needs. Currently you can choose between having no slug, or having - or _. If approved my change will add full width － and ＿.

[tkkuma-k]

@digiguru
Thank you!
After I think again and I have an essential thing to tell you.
When we use the full-width alphabet, number, or kanji character, we also use full-width space '　', not normal space ' '.
I think these two spaces are different. Is this right?
If so, I think it is a better way that normal space ' ' will be '-' or '_', and full-width space '　' will not be changed.

'Some Title' => 'some_title.md'
'Ｓｏｍｅ Ｔｉｔｌｅ' => 'ｓｏｍｅ_ｔｉｔｌｅ.md'
'Ｓｏｍｅ　Ｔｉｔｌｅ' => 'ｓｏｍｅ　ｔｉｔｌｅ.md'

We may not need full width － and ＿ options.
Thank you!

[jevakallio]

Fixed by Markdown Notes v0.0.11! Thanks @digiguru for implementation, @tkkuma-k for testing and feedback, and @kortina for merging and releasing!

https://github.com/kortina/vscode-markdown-notes/releases/tag/v0.0.11

[riccardoferretti]

Due to the high volume of issues, we're closing out older ones without recent activity. Please open a new issue if you need help!