Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching "getHolidays" #460

Closed
derTobsch opened this issue Feb 12, 2024 · 0 comments · Fixed by #474
Closed

Caching "getHolidays" #460

derTobsch opened this issue Feb 12, 2024 · 0 comments · Fixed by #474
Labels
status: new Initial state for every issue / pull request topic: performance type: enhancement A general enhancement
Milestone
0.27.0

Comments

@derTobsch
Copy link
Contributor

More information

The isHoliday method features a caching implementation, meaning that when a holiday is requested, it is cached for future reference. Leveraging this caching mechanism within the getHoliday function can optimize performance, as it avoids repeating the entire code execution for every call within the classpath. Since the XML files remain static during runtime, this caching mechanism is particularly advantageous, effectively accelerating the library's operations.
@derTobsch derTobsch added status: new Initial state for every issue / pull request topic: performance type: enhancement A general enhancement labels Feb 12, 2024
This was referenced Feb 29, 2024
Merged
Merged
@derTobsch derTobsch added this to the 0.27.0 milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: new Initial state for every issue / pull request topic: performance type: enhancement A general enhancement
Projects
None yet
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

Improve getHoliday caching and improve ops/s focus-shift/jollyday
1 participant
@derTobsch