Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Panel broken with theme #68

Open
hendrikbl opened this issue Mar 16, 2018 · 3 comments
Open

Modal Panel broken with theme #68

hendrikbl opened this issue Mar 16, 2018 · 3 comments

Comments

@hendrikbl
Copy link

The modal showing the citations when using \cite is broken when using some themes, e.g. atom-material-ui (it looks like this atom-material/atom-material-ui#414).

I found that this is caused by the two classes overlay and from-top used for the select-list div. Since these clsases are already used in the parent atom-panel, it seems that they are not needed in this div. Without these classes the modal works fine with every theme.

I'm not sure if/when they changed this behaviour and if this is the right way to fix it. While it is broken in some themes, it works with others. So it could be an issue with the theme but this at least fixes it...

@TheIdealis
Copy link

@hendrikbl I'am glad that you found the error, or at least a quick fix. Unfortunately, I couldn't understand your explanation in atom-material-ui/#414 for how two fix the bug, i.e. which classes I have two delete in which files.
Could you give me a little more detail, so that I can fix it myself, until this issue is closed?

@hendrikbl
Copy link
Author

hendrikbl commented Apr 11, 2018

@TheIdealis You have to remove @addClass('overlay from-top cite-view') from cite-view.coffee and label-view.coffee.

@TheIdealis
Copy link

Works like a charm, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants