Trying to test with collection_tests but getting error

[jsirex]

  Fog::Compute[:or2] | Collections | servers (or2)
    success
      #new({"image"=>"image-94d5", "shape"=>"XL", "keyName"=>"keypair-dc10"}) + succeeds
      #create({"image"=>"image-94d5", "shape"=>"XL", "keyName"=>"keypair-dc10"}) + succeeds
      #all + succeeds
      #get(instance-302a) + succeeds
      Enumerable
        #all - succeeds
          expected => true
          returned => false

1. Method collection.all testing twice.
2. collection_tests tries to pass block to method all which actually doesn't accept blocks.

How it designed? Should I implement possibility to pass block to method "all" or this is really bug?

[geemus]

@jsirex could you share a link to where the test files are? I think that might help me narrow in on the issue. Thanks!

[jsirex]

Here is collection_tests helper: https://github.com/fog/fog-core/blob/master/lib/fog/test_helpers/collection_helper.rb#L33-L49

You're testing Enumerable with list of methods. First of them is #all. Test again?

Here you're trying to pass block to method #all. https://github.com/fog/fog-core/blob/master/lib/fog/test_helpers/collection_helper.rb#L46

I've work-a-rounded this method by updating all my collections to accept block:

...
Class MyCollection < Fog::Collection
  # This one doesn't work
  def all
    data = service.get_data(...)
    ...
  end

  # Does work
  def all
    data = service.get_data(...)
    ...
    yield if block_given?
  end
end

[geemus]

Hmm. I'm not sure. We have examples in other places that seem to NOT yield, but still pass, ie:

• https://github.com/fog/fog-aws/blob/916351a3532e80a0318e766ec12bb87fa2348350/lib/fog/aws/models/compute/addresses.rb#L54
• https://github.com/fog/fog-aws/blob/916351a3532e80a0318e766ec12bb87fa2348350/tests/models/compute/addresses_tests.rb

I'm not seeing what the difference is there off hand though.

[jsirex]

First time I've wrote exactly as in your example. But it doesn't work for me. Used ruby 2.1.5.

Actually, I'm not a "ruby profi" and can't understand why addresses_tests in your example works for you.
https://github.com/fog/fog-core/blob/master/lib/fog/test_helpers/collection_helper.rb#L46 - here method #all called with ruby block parameter. But in method itself this block never called (no yield statement, no block.call).

[geemus]

You know, as I dig deeper here, I think there is a typo. Namely, I think that is supposed to be all? and that the block part should work because it is a method mixed in from enumerable (where all those methods accept blocks) see: http://ruby-doc.org/core-2.2.3/Enumerable.html

Will push a fix in a moment, sorry for the confusion.