Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws|iam] Don't pass :host to Excon request #2292

Merged
merged 1 commit into from Oct 21, 2013
Merged

[aws|iam] Don't pass :host to Excon request #2292

merged 1 commit into from Oct 21, 2013

Conversation

bousquet
Copy link
Contributor

Related issues: #2262, #2265 & #2284. Tested on my AWS account scripts.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.38%) when pulling cc5f41b on bousquet:aws-iam-excon-warning into 5885353 on fog:master.

@geemus
Copy link
Member

geemus commented Oct 21, 2013

@bousquet - thanks!

geemus added a commit that referenced this pull request Oct 21, 2013
@geemus
Merge pull request #2292 from bousquet/aws-iam-excon-warning
f25462b 
[aws|iam] Don't pass :host to Excon request
@geemus geemus merged commit f25462b into fog:master Oct 21, 2013
@jtopper jtopper mentioned this pull request Oct 22, 2013
Merged
philk added a commit to philk/fog that referenced this pull request May 1, 2014
@philk
[zerigo] Fix Invalid Excon request warning
765b841 
This was triggering the warning:
`[excon][WARNING] Invalid Excon request keys: :host`

Followed by a stacktrace. Looking at [fog#2292][1] and the related
issues this seems like the right fix and seems to work fine.

[1]: fog#2292
@philk philk mentioned this pull request May 1, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bousquet @coveralls @geemus