[AWS] S3 and public non signed urls

[10io]

This issue comes from this post on the mailing list.

In a nutshell: how to get the public (non signed) url of a public s3 object? (By public object, I mean created with the option :public => true).

Right now, there isn't a straightforward way to do that. You can either build the url using something like "https://#{bucket_name}.s3.amazonaws.com/#{object_name}" or use the underlying service object with something like service.request_url(:bucket_name => "foo", :object_name => "bar").

The idea is to have a more convenient way to do this.

From the linked post, we have two suggestions:

• the "direct" way: a method get_public_http_url on Fog::Storage::AWS::Files (see the existing methods get_http_url and get_https_url)
• Enhance the existing get_http_url and get_https_url methods to support a :public => true option.

Thoughts?

[geemus]

Thanks for the detailed summary.

I suspect that the method signature may tie our hands, in particular it looks like:

def get_http_url(key, expires, options = {})

In the public case, expires wouldn't make any sense, so perhaps it would be better to stick to a new method that just takes the key and returns the constructed value. What do you think?

[10io]

@geemus Ah yes, you're right: the expires parameter doesn't make any sense for a public url.

I'd say, let's go with two new methods get_public_http_url and get_public_https_url. I'll have a shot at creating a PR for this 🔧

Thanks!

[geemus]

@10io great, sounds like a plan. I'm going to close this for now then and await the pull. Thanks!