Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Including GLFW as a submodule #2

Closed
dykatz opened this issue Dec 7, 2013 · 6 comments
Closed

Enhancement: Including GLFW as a submodule #2

dykatz opened this issue Dec 7, 2013 · 6 comments

Comments

@dykatz
Copy link

dykatz commented Dec 7, 2013

We would no longer have to download GLFW separately for it to work, it would become easier to set up and run, and it would always be up to date.

@fogleman
Copy link
Owner

fogleman commented Dec 7, 2013

How is this accomplished? I'm new to cmake.

@dykatz
Copy link
Author

dykatz commented Dec 7, 2013

It isn't something done with cmake; it's done with git. This document from the official git site is a pretty good resource for this.

@fogleman
Copy link
Owner

fogleman commented Dec 7, 2013

Done!

@fogleman fogleman closed this as completed Dec 7, 2013
@dykatz
Copy link
Author

dykatz commented Dec 7, 2013

Sweet! You may want to consider updating the read me.

@fogleman
Copy link
Owner

fogleman commented Dec 7, 2013

Hmm, didn't realize that git clone wouldn't recursively pull the submodules. Not sure if I love this approach now.

@dykatz
Copy link
Author

dykatz commented Dec 7, 2013

I just found this article, which may explain it better. To use git clone recursively, you just need to use --recursive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants