Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Exclude files already present. #80

Open
sorenwacker opened this issue Mar 4, 2022 · 1 comment
Open

FR: Exclude files already present. #80

sorenwacker opened this issue Mar 4, 2022 · 1 comment
Labels
feature request Have an idea that might be worth implementing?

Comments

@sorenwacker
Copy link

It would be nice if duplicate uploads could be prevented somehow. I sometimes have a thousand files, and I am not sure which ones are already on the server. Uploading the whole batch is wasteful and looking through each file is tedious. Maybe a list of filenames to blacklist would be good.

BTW I like that the upload ignores files with the wrong extension instead of raising an alarm. I know that is what you would like to implement. If so, please make it optional.

@fohrloop
Copy link
Owner

fohrloop commented Mar 5, 2022

I think there could be a logic that is user-controllable: Either reupload files with same name or do not reupload. Maybe in the future it could also check the file size and/or last modified date (not sure how easy that would be).

One potential problem with this might arise if uploading a file structure with subfolders is supported in such a way that files are always put into a folder structure at the server side. This is because I'm unsure if all the browsers support sending the relative filepath of the selected files, if they are inside a subfolder. If user first uploads with Chrome (that supports sending relative filepaths), and then re-uploads with different browser (which does not support relative filepaths), the files could be mistakenly intepreted to be "missing".

The current version in the dev branch raises an alarm for wrong extensions and does not upload them, but continues the upload process for the rest of the files. I think there could be added different options in the future ("raise error and do not continue", "silently continue" ,... etc), if needed.

@fohrloop fohrloop added the feature request Have an idea that might be worth implementing? label Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Have an idea that might be worth implementing?
Projects
None yet
Development

No branches or pull requests

2 participants