Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos? #50

Closed
adrift2000 opened this issue Sep 27, 2016 · 3 comments
Closed

Typos? #50

adrift2000 opened this issue Sep 27, 2016 · 3 comments

Comments

@adrift2000
Copy link
Contributor

Take a look at the "f" function https://github.com/devongovett/fontkit/blob/master/src/glyph/Path.js#L82
Does it refers to this loop variable: https://github.com/devongovett/fontkit/blob/master/src/glyph/Path.js#L120? But it has been declared using the let keyword so it never be visible to "f".

https://github.com/devongovett/fontkit/blob/master/src/glyph/CFFGlyph.js#L454
https://github.com/devongovett/fontkit/blob/master/src/glyph/CFFGlyph.js#L492
The "i" is undeclared.

@devongovett
Copy link
Member

Good catches. Probably caused by the somewhat automatic translation from the original CoffeeScript. Can you submit a PR to fix?

@adrift2000
Copy link
Contributor Author

#51
#52

@devongovett
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants