Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: signature doesn't work when using the same buffer in different windows #593

Closed
3 tasks done
ofirgall opened this issue Sep 11, 2023 · 0 comments · Fixed by #616 or #639
Closed
3 tasks done

bug: signature doesn't work when using the same buffer in different windows #593

ofirgall opened this issue Sep 11, 2023 · 0 comments · Fixed by #616 or #639
Labels
bug Something isn't working

Comments

@ofirgall
Copy link

Did you check docs and existing issues?

  • I have read all the noice.nvim docs
  • I have searched the existing issues of noice.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.9.2-dev-a3889e7

Operating system/version

Ubuntu 22.04.1 LTS

Describe the bug

When I split a buffer to two windows the signature doesn't work on the right window but works on the left window.

I did some debugging, get_char function in lsp/signature gets the char by using the bufwinid.
bufwinid doesn't return the active window if the buffer exists in 2 windows therefore it doesn't work for the second window.

I changed vim.fn.bufwinid(buf) to vim.api.nvim_get_current_win() and it fixes the problem, but it doesn't take buf in account.

Steps To Reproduce

  1. Open buffer
  2. Make a split to the same buffer
  3. Try to use the signature feature in the new window

Expected Behavior

Signature feature should work on the 2nd window as well

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/noice.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here
@ofirgall ofirgall added the bug Something isn't working label Sep 11, 2023
@folke folke closed this as completed in 2f0993e Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant