Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semantic_tokens): link method and functions with defaultLibrary modifier to @function.builtin #333

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

jdrouhard
Copy link
Contributor

@jdrouhard jdrouhard commented Mar 8, 2023

Added link for @lsp.typemod.method.defaultLibrary to complement the one for @lsp.typemod.function.defaultLibrary and made them both link to @function.builtin (which fallback to Special).

@folke
Copy link
Owner

folke commented Mar 10, 2023

Hi! Love the new semantic tokens PR, but I still need to figure out if there's anything cool I can do with it.

I personally prefer having parameters the same hl group though :)

Can you update the PR and just keep the method.defaultLibrary?

IF you have any great ideas on some other stuff we could add to TokyoNight for semnatic tokens, let me know!

@jdrouhard jdrouhard changed the title feat(semantic_tokens): highlight references to function parameters with a lighter shade feat(semantic_tokens): link method and functions with defaultLibrary modifier to @function.builtin Mar 11, 2023
@jdrouhard
Copy link
Contributor Author

Ping @folke - done. Took out the experimental stuff and just added a link for method.defaultLibrary

@folke folke merged commit e051206 into folke:main Mar 12, 2023
@folke
Copy link
Owner

folke commented Mar 12, 2023

thanks!

@jdrouhard jdrouhard deleted the lsp-parameter-reference-hl branch March 12, 2023 19:22
riley-martine pushed a commit to riley-martine/tokyonight.nvim that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants