fix(barbar): CurrentBackground

[otavioschwanck]

Before (Low icon contrast):

After:

[patricio-ferraggi-deel]

Super personal but I don't enjoy this change or the separator change. The BufferTabPageFill becomes almost like a grey thing that doesn't match the rest of the theme. I rolled back till this commit, because there are also other changes into the separator.

btw this is how it looks before this change for me

So beautiful, more than enough contrast. Maybe these changes could be applied only to a style and not the entire theme? @folke @otavioschwanck

I am using night style

[otavioschwanck]

Super personal but I don't enjoy this change or the separator change. The BufferTabPageFill becomes almost like a grey thing that doesn't match the rest of the theme. I rolled back till this commit, because there are also other changes into the separator.

btw this is how it looks before this change for me

So beautiful, more than enough contrast. Maybe these changes could be applied only to a style and not the entire theme? @folke @otavioschwanck

I am using night style

The Active background icon contrast problem that was fixed is not for every icon, just some. Every change was made based on another editors (VSCode has a similar approach to the contrasts).

Personally, i find it must more elegant and less intrusive then before. Less pollution on the screen, the current tab is more clear, the active background tab mixes with the editor bg (like vscode as example), and i can still see the inactive tabs.

I could make the inactive more visible, like that:

Thats possible.

VScode example:

EDIT:

i admit that on the night variant the bar could be darker. I will see what i can do.

EDIT 2:

Made that change:

Example 1:

Example 2 (darker tabfill):

Thats good for you ? @pferraggi

[patricio-ferraggi-deel]

Hi, I prefer the darker tabfill (example 2), maybe that is also why I like the night variant? 😆 . Thanks for taking the time to answer and try it out 😄

[otavioschwanck]

Hi, I prefer the darker tabfill (example 2), maybe that is also why I like the night variant? 😆 . Thanks for taking the time to answer and try it out 😄

Merged. A tip: The current separator of barbar messes the padding. If it bothers you, you can copy my config:

      require('bufferline').setup({
        hide = {extensions = true},
        icons = {
          -- Configure the base icons on the bufferline.
          buffer_index = false,
          buffer_number = false,
          button = '',
          -- Enables / disables diagnostic symbols
          diagnostics = {
            [vim.diagnostic.severity.ERROR] = {enabled = true, icon = 'ff'},
            [vim.diagnostic.severity.WARN] = {enabled = false},
            [vim.diagnostic.severity.INFO] = {enabled = false},
            [vim.diagnostic.severity.HINT] = {enabled = false},
          },
          filetype = {
            custom_colors = false,
            enabled = true,
          },
          separator = {left = '', right = '▕'},
          modified = {button = '●'},
          pinned = {buffer_index = true, filename = true, button = '', separator = { right = '▕', left = ''} },
          alternate = {filetype = {enabled = false}},
          current = {buffer_index = false},
          inactive = {button = '', separator = {left = '', right = '▕'}},
          visible = {modified = {buffer_number = false}},
        },
        sidebar_filetypes = {
          ['neo-tree'] = {event = 'BufWipeout'},
        },
        exclude_ft = {'netrw'},
        highlight_visible = false,
      })

[patricio-ferraggi-deel]

Hi, I prefer the darker tabfill (example 2), maybe that is also why I like the night variant? 😆 . Thanks for taking the time to answer and try it out 😄

Merged. A tip: The current separator of barbar messes the padding. If it bothers you, you can copy my config:

      require('bufferline').setup({
        hide = {extensions = true},
        icons = {
          -- Configure the base icons on the bufferline.
          buffer_index = false,
          buffer_number = false,
          button = '',
          -- Enables / disables diagnostic symbols
          diagnostics = {
            [vim.diagnostic.severity.ERROR] = {enabled = true, icon = 'ff'},
            [vim.diagnostic.severity.WARN] = {enabled = false},
            [vim.diagnostic.severity.INFO] = {enabled = false},
            [vim.diagnostic.severity.HINT] = {enabled = false},
          },
          filetype = {
            custom_colors = false,
            enabled = true,
          },
          separator = {left = '', right = '▕'},
          modified = {button = '●'},
          pinned = {buffer_index = true, filename = true, button = '', separator = { right = '▕', left = ''} },
          alternate = {filetype = {enabled = false}},
          current = {buffer_index = false},
          inactive = {button = '', separator = {left = '', right = '▕'}},
          visible = {modified = {buffer_number = false}},
        },
        sidebar_filetypes = {
          ['neo-tree'] = {event = 'BufWipeout'},
        },
        exclude_ft = {'netrw'},
        highlight_visible = false,
      })

Thanks, indeed it was bothering me 😆