Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make day diff highlights more readable #362

Closed
wants to merge 1 commit into from

Conversation

riley-martine
Copy link
Contributor

Day diff highlights for delta are hard to read. See before and after:

Screenshot 2023-04-08 at 2 49 33 PM

Very willing to adjust colors, if these are not as desired. (The blue and green might clash a bit?) I fiddled a bit, but had trouble finding something that's distinct from the other background color, but doesn't have significantly worse contrast with the text than that bg color.

(Working on a fix for the _style_name and other bits being hard to read against blue -- these are set in the sublime colors to fixed values regardless of theme. This gets used for the bat colors which delta uses for syntax highlighting. I'm trying to get something that preserves mostly how the dark themes look, but makes day easier to read. Don't want to mess up anyone's existing theme if they like it, yknow.)

@folke
Copy link
Owner

folke commented Apr 22, 2023

The problem was actually the colors. Delta. Colors shouldn't be defined in an extra since for the day theme, the colors are automatically generated.

I moved the color defs to colors.lua, so that should now be correct.

Feel free to open another PR with changes to the sublime scheme!

riley-martine pushed a commit to riley-martine/tokyonight.nvim that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants