fix: make day diff highlights more readable #362
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Day diff highlights for delta are hard to read. See before and after:
Very willing to adjust colors, if these are not as desired. (The blue and green might clash a bit?) I fiddled a bit, but had trouble finding something that's distinct from the other background color, but doesn't have significantly worse contrast with the text than that bg color.
(Working on a fix for the
_style_name
and other bits being hard to read against blue -- these are set in the sublime colors to fixed values regardless of theme. This gets used for thebat
colors whichdelta
uses for syntax highlighting. I'm trying to get something that preserves mostly how the dark themes look, but makes day easier to read. Don't want to mess up anyone's existing theme if they like it, yknow.)