Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed alacritty .yml to .toml #450

Merged
merged 3 commits into from Jan 20, 2024
Merged

Conversation

jspsv
Copy link
Contributor

@jspsv jspsv commented Oct 26, 2023

First off, thanks for this theme (I use it everywhere), it's absolutely beautiful!
Alacritty is moving its config format from YAML to TOML. With this change, the current theme still work, but will show a deprecation warning (at least on alacritty 0.13.0-dev (75eef3be)).

This PR generates the theme as .toml files. I could not generate them using the command from the README (somehow still produces .yml files), but it does generate .toml files the following (from commit):

nvim -u NONE -E -R --headless --cmd "set rtp^=." --cmd "packloadall" --cmd "lua require('tokyonight.extra').setup()" --cmd qa

Tested on alacritty 0.13.0-dev (75eef3be). Additional changes may be required to get the files to generate correctly.

Copy link

@antonkesy antonkesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also add the respective .toml-files in extras/alacritty/*.yml?

@adrian5
Copy link
Contributor

adrian5 commented Dec 29, 2023

With Alacritty 0.13 being released, maybe we can ditch the YAML version after all. Normally I'd agree to supply both, but Alacritty is the type of application where users don't stay on older versions for months.


P.s. There's also the cursor setting which I think most users of terminal editors (like vim) will want. Not sure how you feel about adding that, maybe in a commented-out state. Since TokyoNight extras aren't meant for seamless background installation but require some manual copying, I think that's justifiable.

[colors.primary]
background = "#222436"
foreground = "#c8d3f5"

#[colors.cursor]
#cursor = "#c8d3f5"
#text = "#222436"

@adrian5
Copy link
Contributor

adrian5 commented Dec 29, 2023

@jspsv: by the way, this section is no longer needed:

  local alacrittyColors = {}
  for k, v in pairs(colors) do
    if type(v) == "string" then
      alacrittyColors[k] = v:gsub("^#", "0x")
    end
  end

It was meant to convert #rrggbb to 0xrrggbb back when Alacritty only accepted that format. Now the default color format should be right as-is. Take a look at other templates where the defaults suffice to assure yourself about yours.

@folke
Copy link
Owner

folke commented Jan 20, 2024

Thanks!

patnr added a commit to patnr/tokyonight.nvim that referenced this pull request Mar 5, 2024
* up-main: (29 commits)
  chore(build): auto-generate vimdoc
  chore(build): auto-generate extras
  fix(treesitter): correctly link up delimiters again
  chore(build): auto-generate vimdoc
  chore(build): auto-generate extras
  fix: re-add `@punctuation.special` (folke#484)
  chore(main): release 3.0.1 (folke#479)
  chore(build): auto-generate extras
  fix(treesitter): defaults for @namespace.builtin
  chore(build): auto-generate vimdoc
  chore(build): auto-generate extras
  fix(treesitter): consolidate notes
  chore(main): release 3.0.0 (folke#475)
  chore(build): auto-generate extras
  feat(wezterm): add color for scrollbar (folke#470)
  feat: changed alacritty .yml to .toml (folke#450)
  chore(build): auto-generate vimdoc
  chore(build): auto-generate extras
  feat(extras): add fzf colors (folke#464)
  chore(build): auto-generate extras
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants