Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check parent window is valid before setting active #291

Merged
merged 1 commit into from Jun 3, 2023
Merged

Check parent window is valid before setting active #291

merged 1 commit into from Jun 3, 2023

Conversation

jgoguen
Copy link
Contributor

@jgoguen jgoguen commented Jun 3, 2023

When exiting neovim with only one window open (besides trouble), there's no parent window to set active. This verifies that the parent window is valid before setting it active.

With this in place, neovim exits cleanly when trouble is the last window open. If there is another window, that window becomes active and neovim does not exit.

Fixes #284

@folke folke merged commit c14786d into folke:main Jun 3, 2023
@folke
Copy link
Owner

folke commented Jun 3, 2023

thanks!

@jgoguen jgoguen deleted the exit-last-window branch June 3, 2023 15:09
@xu-cheng
Copy link

xu-cheng commented Jun 7, 2023

@jgoguen This doesn't fix the problem unfortunately. See #284 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Error on exit buffer when trouble list is opened
3 participants