Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiline diagnostic support #305

Merged
merged 6 commits into from Jul 22, 2023
Merged

Add multiline diagnostic support #305

merged 6 commits into from Jul 22, 2023

Conversation

MariaSolOs
Copy link
Contributor

@MariaSolOs MariaSolOs commented Jul 18, 2023

Fixes #279, #268 and #11

A preview of how this looks:
image

@folke
Copy link
Owner

folke commented Jul 20, 2023

Thank you for this PR!

I'll look into it later today, but I think this potentially breaks actions and folds on the different lines. Maybe not though, need to check :)

@MariaSolOs
Copy link
Contributor Author

Thank you for this PR!

I'll look into it later today, but I think this potentially breaks actions and folds on the different lines. Maybe not though, need to check :)

Thanks to you! There are a couple of design questions in #279 but we should definitely first make sure this doesn’t break anything.

@eatgrass
Copy link
Contributor

eatgrass commented Jul 21, 2023

@MariaSolOs @folke
please check the screenshot. How about keeping the first line in the entry, it seems more consistent
image

@folke
Copy link
Owner

folke commented Jul 22, 2023

I've made multiline configurable and changed the layout as @eatgrass suggested.
Still have to check if multline possibly breaks something

@folke folke merged commit 7a6abd7 into folke:main Jul 22, 2023
3 checks passed
@folke
Copy link
Owner

folke commented Jul 22, 2023

All seems to work as it should. Merged. Thank you!

Edit: made multiline the default

@MariaSolOs
Copy link
Contributor Author

All seems to work as it should. Merged. Thank you!

Edit: made multiline the default

Thanks to you! I hope people like the new layout as much as I do ☺️

@kting28
Copy link

kting28 commented Jul 22, 2023

Thanks @MariaSolOs

@MariaSolOs MariaSolOs deleted the multiline-diags branch July 23, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: two line error messages concatenated without space inbetween (Rust analyzer errors)
4 participants