Create Configuration for IncludeDeclaration #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this setting was defaulted to true. Now, it will only be set to true for modes that are explicitly named.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, when
references,implementations, ordefinitionsis called,includeDeclarationis set totrueby default.This is cumbersome when you are on a definition and call
lsp_referenceswhen there is only 1 reference. Instead of instantly jumping to said reference, a Trouble window appears including that sole reference as well as the your current position.I'm sure there may be other scenarios, but this is the one I most frequently run into.
This PR
This PR adds a
include_declarationlist in the config. Only modes that are in this list willinclude_declarationset totrue. All current modes using it have been set as a default so it doesn't break anyones workflow.