Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 resolution in pnp subpackages #150

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

remorses
Copy link
Contributor

resolveRequest second argument requires a file path and not a directory,

Previously commands from sub packages would silently throw Your application tried to access module not listed in your dependencies because of this

@remorses
Copy link
Contributor Author

Hey @folke, did you take a look at this PR?

Copy link
Owner

@folke folke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't see this one indeed 😬

Will push a new release later today!

@folke folke merged commit 823def0 into folke:master Dec 24, 2020
folke pushed a commit that referenced this pull request Dec 24, 2020
## [3.8.0](v3.7.1...v3.8.0) (2020-12-24)

### Features

* ✨ set default concurrency to number of cpus ([a63c3d5](a63c3d5))

### Bug Fixes

* 🐛 add `-h` as alias for `--help` ([439f8cf](439f8cf))
* 🐛 resolution in pnp subpackages ([#150](#150)) ([823def0](823def0))

### Other

* 📦️ fix semantic-release script ([8c1b81c](8c1b81c))
* 📦️ fix semantic-release script ([a90c790](a90c790))
* 📦️ fix semantic-release script ([c13472b](c13472b))
* **deps:** 🔗 udpates ([f7a062b](f7a062b))
* **deps:** pin dependencies ([#146](#146)) ([f44b70e](f44b70e))
* **deps:** update actions/setup-node action to v2 ([#148](#148)) ([d5b44b9](d5b44b9))
* **deps:** update all non-major dependencies ([#147](#147)) ([1d317e1](1d317e1))
* **deps:** update dependency eslint-plugin-unicorn to v24 ([#149](#149)) ([32eeb3d](32eeb3d))
@folke
Copy link
Owner

folke commented Dec 24, 2020

🎉 This PR is included in version 3.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@folke folke added the released label Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants