fix(ultraignore): allow ultraignore to work with tracked git files #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying out the new
.ultraignore
feature, I found a bug where you could not ignore files tracked by git.After looking into this, it is because the
git ls-files -X <file>
does not work for files being tracked in git. In my case, I wanted to ignorejest.config.js
as well as test files undersrc/
.This PR uses the popular node-ignore package to parse the
.ultraignore
file and excludes its entries directly at the cache level.Note that I have a failing test on my machine. This was failing before making my change, and I think it is environment-specific. Maybe I am on a newer version of
npx
than the one these tests were written with?I did add a test for the new
.ultraignore
behavior.