-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always sync before select? #34
Comments
Ha, just left you a note on the visual studio marketplace about feature requests and seems you already posted one :) Definitely possible. I'll look into it tomorrow! |
Just to be clear:
Initially I thought you wanted to have the "sync" happen automatically when opening VSCode, but this is probably not what you want. Things probably already work as you would like them to work. I might need to rename sync to something different though, since it might be a bit confusing for sure... |
Thinking about it, I should probably remove the sync option altogether, since using |
That sounds good to me. If that's the case, though, I think there's a bug when you create new subpackages. Neither sync nor select picks them up. Given: {
"packages": ["apps/*", "libs/*"]
} Then: lerna create new-pack Only a restart, then a sync will get it to show up. (First time it happened, some combination of syncs and selects got it to work for me, and that's why I opened this issue.) |
Looks indeed like a bug. Something is probably cached somewhere. I'll have a look! |
I just checked and it seems to work as expected on my end. However, I think it's because you're using Lerna together with Yarn Workspaces. When using both, we use the detector for Yarn, which should be in sync with Lerna anyways, for Lerna to work properly. Can you check the following things?
{
"workspaces": {
"packages": ["apps/*", "libs/*"]
}
} |
Nah, I use npm. Been holding out for npm workspaces for like two years now. ;) But I did some further digging, and the problem was a mix of me doing something wrong and lerna doing something wrong. I was running But the fact remains that In any case, thanks again for the plugin (and for ultra, which I'm playing around with now). It really helps clean up the project. |
Glad you figured it out! Have fun with |
Hey, I love the plugin! Just wondering if you could set it to always sync before opening the select GUI. I think this would definitely help streamline the UI.
The text was updated successfully, but these errors were encountered: