Compatibility with Vim Visual Multi plugin #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@folke would you be opposed to merging this PR (sorry for the ping) this multi cursor plugin is essentially the de facto MC plugin and the incompatibility between these two plugins is pretty inconvenient 🙏🏿 |
|
@akinsho done! :) |
njhoffman
pushed a commit
to njhoffman/which-key.nvim
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #115
hack but works. The underlying problem is caused by which-key popup, which invalidates visual-multi state. This PR checks if before opening WKey popup we were in Visual-multi-mode, if so, then reapply last visual multi state - vim.cmd[[normal \gS]]