Fix mapping when right-hand side is nil
#323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only seems to occur with '!' on the left-hand side
xaviervalarino
changed the title
nilnil #324
xaviervalarino
changed the title
nil #324nil
|
AS a workaround until this is merged as Neovim is pretty much not usable without which-key: |
njhoffman
pushed a commit
to njhoffman/which-key.nvim
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a keymap has
!on the left-hand side and an anonymous function on the right-hand side, mapargs returns a table with norhs, which breaks the test againstcmd. This only seems to be an issue for this specificlhsvalue.This PR is a simple fix: it checks to make sure
rhsexists before testing againstcmd.