Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Add page no in the bottom #4

Closed
shadmansaleh opened this issue Apr 28, 2021 · 9 comments · Fixed by #383
Closed

Feature : Add page no in the bottom #4

shadmansaleh opened this issue Apr 28, 2021 · 9 comments · Fixed by #383

Comments

@shadmansaleh
Copy link
Contributor

Currently the popup always says to scroll up and to scroll down . But there's no indicator how far can be scrolled or if there are maps out of page at all . A count at the bottom will help understand how many pages are left that can be scrolled .

@folke
Copy link
Owner

folke commented Apr 28, 2021

Great idea, or maybe only show the up/down mappings if you can scroll?

@folke folke closed this as completed in 9e7986d Apr 28, 2021
@folke
Copy link
Owner

folke commented Apr 28, 2021

Fixed!

@shadmansaleh
Copy link
Contributor Author

Fixed!

Wow you're fast

@shadmansaleh
Copy link
Contributor Author

Ok displaying scroll up and down only when scrolling is possible is nice . But a count'll be better I think . Also scroll up and down should probably be independent (show scroll up when scrolling up is possible and scroll down when scrolling down is possible)

@pschmitt
Copy link

Was about to open for this.
Is there a way to disable the message altogether I may have missed in the docs?
I'm asking cause since I have a lot of leader mappings, when pressing my leader I do get greeted by:

<leader><c-d> scroll down <c-u> scroll up <bs> go up one level <esc> close
Press ENTER or type command to continue

which is kinda annoying since you then have to press 2 keys to launch the mapped command (one for dismissing said text, and another for the mapping). Thanks for this plugin btw!

@folke
Copy link
Owner

folke commented Apr 28, 2021

@pschmitt I'll add in an option. The Press ENTER shouldn't show though. Can you post a screenshot of the full width of the line? There's must be something on the right.

@shadmansaleh
Copy link
Contributor Author

which is kinda annoying since you then have to press 2 keys to launch the mapped command (one for dismissing said text, and another for the mapping).

Did you try ?

set cmdheight=2

@folke
Copy link
Owner

folke commented Apr 28, 2021

@pschmitt just pushed a change for configurin help with show_help = false

@pschmitt
Copy link

@folke sweet, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants