Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow deviating paddings per side #400

Merged
merged 1 commit into from Apr 17, 2023
Merged

fix: allow deviating paddings per side #400

merged 1 commit into from Apr 17, 2023

Conversation

ttytm
Copy link
Contributor

@ttytm ttytm commented Jan 30, 2023

This PR allows the use of deviating paddings per side.

Currently, it won't work to set another padding for top then for bottom for example. It also cleans up variables a bit.

Here are some screenshots:

Adding padding top has no effect:

Screenshot_20230417_011706

Changing padding bot changes both:

Screenshot_20230417_011728

Allowing deviating values, e.g. top = 1, bot = 0 works quite nice with cmdheight = 0. Looks uniform.

Screenshot_20230417_010745

Please let me know about desired changes and feel free to modify the PR.

@ttytm
Copy link
Contributor Author

ttytm commented Apr 16, 2023

Hey @folke, hope you are good! When there is not too much work, let me know if this one can make it.

I'm cleaning up some forks and branches and seen it would be a quick review.

I updated the PR description to include some screenshots.

@folke folke merged commit 3090eaf into folke:main Apr 17, 2023
@folke
Copy link
Owner

folke commented Apr 17, 2023

Thanks!

@ttytm ttytm deleted the fix-deviating-paddings-per-side branch April 17, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants