Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(view): ensure it's above other floating windows #442

Merged
merged 2 commits into from Apr 18, 2023
Merged

feat(view): ensure it's above other floating windows #442

merged 2 commits into from Apr 18, 2023

Conversation

LoneExile
Copy link
Contributor

Ensure the which-key window appears above other floating windows,
such as the LSP diagnostics or terminal that floats.
This improves visibility when using the which-key plugin.

Copy link
Contributor

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zindex should be a user configurable setting if it is added imho.

@LoneExile
Copy link
Contributor Author

Zindex should be a user configurable setting if it is added imho.

Sure thing! I agree that making the z-index user configurable would be a better approach.
How about adding the z-index option within the 'window' table like this?

window = {
    border = "none",
    position = "bottom",
    margin = { 1, 0, 1, 0 },
    padding = { 1, 2, 1, 2 },
    winblend = 0,
    zindex = 1000 -- new user configurable option
},

@folke
Copy link
Owner

folke commented Apr 18, 2023

Great idea!

@LoneExile
Copy link
Contributor Author

I've made the requested changes and updated the README.md and default config to include the user-configurable z-index setting.
Please take a look and let me know if any further adjustments are needed. Thanks!

@folke folke merged commit 9443778 into folke:main Apr 18, 2023
@folke
Copy link
Owner

folke commented Apr 18, 2023

merged. thanks!

@LoneExile LoneExile deleted the zindex branch May 13, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants