Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does hot reloading handle moving the notebook file? #1506

Closed
fonsp opened this issue Sep 26, 2021 · 3 comments
Closed

How does hot reloading handle moving the notebook file? #1506

fonsp opened this issue Sep 26, 2021 · 3 comments

Comments

@fonsp
Copy link
Owner

fonsp commented Sep 26, 2021

If you change the filename or move the notebook using the filepicker UI, what happens? #1029

@disberd
Copy link
Contributor

disberd commented Oct 2, 2021

I tried creating a new notebook and moving it twice

  • First time from new notebook to specifica path/name
  • Second time just renaming it within the same directory
    Both times I tried updating the contents of the file from VSCode and both times the file change was tracked succesfully.

Is there really anything else to test?

Edit:

Is the filepicker UI this thing on top of the notebook?
image

Because I only did tests with that

@fonsp
Copy link
Owner Author

fonsp commented Oct 5, 2021

@disberd Thanks for testing! 💕 Did you use Windows? Or WSL? No errors in the console?

Is the filepicker UI this thing on top of the notebook?

Yep!

@disberd
Copy link
Contributor

disberd commented Oct 5, 2021

I only did tests on plain Windows, I don't think I even have access to WSL 2 on the work laptop so I never even tried setting anything up

@fonsp fonsp closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants