Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider fails if in CommonMark string #1807

Closed
chunjiw opened this issue Jan 5, 2022 · 6 comments · Fixed by MichaelHatherly/CommonMark.jl#58
Closed

Slider fails if in CommonMark string #1807

chunjiw opened this issue Jan 5, 2022 · 6 comments · Fixed by MichaelHatherly/CommonMark.jl#58
Labels
bug Something isn't working

Comments

@chunjiw
Copy link

chunjiw commented Jan 5, 2022

This is actually #1637. Now I reproduced it in binder. I couldn't reopen that issue so I opened a new one here.

Thank you!

Video and gist:

demo.mp4

https://gist.github.com/chunjiw/d56949081764643ab9a5d205479bc53a

@icweaver
Copy link
Contributor

icweaver commented Jan 5, 2022

oof, yea, I think that might be related to the changes to Slider mentioned here (#148). The old version of the slider still looks to be working I think, but this is def a good thing to keep an eye on!

using PlutoUI.BuiltinsNotebook: OldSlider

cm"$(@bind cm_d OldSlider(0.5:10))"

cm_d

@chunjiw
Copy link
Author

chunjiw commented Jan 5, 2022

Indeed, this issue happens at 0.17.1 and after. I think you are right 👍

@chunjiw chunjiw changed the title @bind fails if in CommonMark string Slider fails if in CommonMark string Jan 5, 2022
@fonsp
Copy link
Owner

fonsp commented Jan 5, 2022

You can use MarkdownLiteral 0.1.1 (just released) instead of CommonMark while we work on this issue

@fonsp fonsp added the bug Something isn't working label Jan 7, 2022
@runjaj
Copy link

runjaj commented Dec 2, 2022

Any progress solving this bug? It drove me crazy a couple of days ago.

@fonsp
Copy link
Owner

fonsp commented Dec 22, 2022

Working on a fix: MichaelHatherly/CommonMark.jl#58

@fonsp
Copy link
Owner

fonsp commented Jan 17, 2023

Fixed in the new CommonMark release ✅

@fonsp fonsp closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants