Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP.jl: remove workarounds in WebSocketFix.jl? #2116

Closed
fonsp opened this issue May 18, 2022 · 1 comment · Fixed by #2185
Closed

HTTP.jl: remove workarounds in WebSocketFix.jl? #2116

fonsp opened this issue May 18, 2022 · 1 comment · Fixed by #2185
Labels
backend Concerning the julia server and runtime enhancement New feature or request HTTP/WS The connection between backend and frontend

Comments

@fonsp
Copy link
Owner

fonsp commented May 18, 2022

This PR added workarounds to Pluto's source code to fix an HTTP.jl bug: #580

A similar fix seems to have entered HTTP.jl some months later: JuliaWeb/HTTP.jl#638

So we might be able to remove https://github.com/fonsp/Pluto.jl/blob/main/src/webserver/WebSocketFix.jl

To test this, you need to send a lot of data over the WS at once. You could try:

@bind x @htl("""
<script>
currentScript.value = new Uint8Array(1000 * 1000 * 10) 
currentScript.dispatchEvent(new CustomEvent("input"))
</script>
""")
@fonsp fonsp added enhancement New feature or request HTTP/WS The connection between backend and frontend backend Concerning the julia server and runtime labels May 18, 2022
@fonsp
Copy link
Owner Author

fonsp commented Jun 16, 2022

We will be able to remove these after upgrading to HTTP 0.10: JuliaWeb/HTTP.jl#843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Concerning the julia server and runtime enhancement New feature or request HTTP/WS The connection between backend and frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant