Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cell button not visible #2313

Closed
VivaldoMendes opened this issue Oct 12, 2022 · 6 comments · Fixed by #2320
Closed

Run cell button not visible #2313

VivaldoMendes opened this issue Oct 12, 2022 · 6 comments · Fixed by #2320
Labels
bug Something isn't working frontend Concerning the HTML editor

Comments

@VivaldoMendes
Copy link

In Pluto v0.19.13, Julia 1.8.2, on a windows machine, the Run cell button is not visible. It used to be visible in previous versions.

@disberd
Copy link
Contributor

disberd commented Oct 13, 2022

I am also running same Pluto and Julia version but still see the button.
I only see it upon hovering with the mouse on a cell but I believe that has also been the case before

@fonsp
Copy link
Owner

fonsp commented Oct 13, 2022

@VivaldoMendes can you make a video recording of the problem? Instructions are here

@VivaldoMendes
Copy link
Author

Hi @disberd and @fonsp,

Sorry for my late reply; I had a busy day. Moreover, I needed to check the problem on different computers to avoid throwing more noise into the problem rather than helping.

I do not understand what is happening, but the problem is simple to explain. We do not need a video, but I will post one if that is the case.

I tested the problem on various Windows computers, some with Julia 1.8.1, others with Julia 1.8.2, all with the latest version of Pluto v0.19.13. The problem is simple: the Run cell button is not visible; it works if we click on its usual place, and the output is obtained as usual. The only problem is that the small round button is not visible. That is all.

I just started a new notebook to make things as simple as possible. Typed 3*3, run the cell, the output is visible, but the run-cell button is seen nowhere. See the figure below.

a2

My configuration can be seen below.

a1

Thanks.

@fonsp
Copy link
Owner

fonsp commented Oct 14, 2022

Hard to tell without a video (@VivaldoMendes could you try to make a video? Instructions are here) but it it possible that OP uses a touch-enabled screen, for which we have some different CSS rules.

@disberd
Copy link
Contributor

disberd commented Oct 14, 2022

I also noticed this now randomly while testing a connection to a remote pluto server through a local browser instance.
For some reason my local pluto server still uses url for svg background images instead of the one directly bundled with Pluto (I thought this only happened if I dev Pluto).
On the server one, I see a bunch of bundled images but the specific one of the run button seems to be broken.

All the others svg can be seen both in the front-end and in the Sources tab in the developer console.
The caret-forward-circle-outline.svg seems instead broken, showing just this if I try to open the bundled image in a separate tab:
image

@fonsp fonsp added bug Something isn't working frontend Concerning the HTML editor labels Oct 14, 2022
@fonsp
Copy link
Owner

fonsp commented Oct 14, 2022

It looks like the file in our bundle is empty: https://github.com/fonsp/Pluto.jl/blob/v0.19.13/frontend-dist/caret-forward-circle-outline.38d394c2.svg

Which is very weird, we check for this situation explicitly:

if (response_length === 0) {
throw new Error(`${specifier} returned an empty reponse.`)
}
await mkdirp(folder)
const write_result = await fs.writeFile(fullpath, buffer)
// Verify that the file was written correctly:
if (write_result !== undefined || (await fs.readFile(fullpath)).length !== response_length) {
throw new Error(`Failed to write file ${fullpath}`)
}

Here is the log (nothing remarkable) https://github.com/fonsp/Pluto.jl/actions/runs/3213822083/jobs/5253777931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants