-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning the file format #311
Comments
Right now it writes the Pluto version to the second line, I thought that this can be used to indirectly version the file format. Do you mean versioning it more explicitly? i.e. call this version 1, and change to 2 in the future? |
Yea exactly, becuse presumable most (all?) Pluto versions can read the same file format? The reason I thought about this is that I thought about making Literate output pluto notebooks, and it would be good to have a specific spec (e.g. version 1) that I can output. |
I thought that the minor version number (minor while in You mentioned erroring instead of adding conversion code, but I do think that we should add conversion code on every change from now on. Otherwise you would have to start all your notebooks again. So in that spirit, outputting any current spec will work for all future versions. |
Yea that is one idea, but then you couple breaking changes to the package API to the breaking changes in the format. But maybe that is fine. In any case, it would be nice to not warn about it for the same breaking version, e.g. Pluto v0.11.8 should not complain about a file with v0.11.0 in the header. |
Does it make sense to move the file format and data structure related stuff from Pluto.jl to a PlutoNotebook.jl package which has only few dependencies ? Then Literate.jl, Pluto.jl and possibly other tools which handle notebooks could rely on this one. |
or AbstractNotebook.jl? @pfitzseb |
Let's revisit this if/when we ever need to change the format, or when VS Code wants to share the format @pfitzseb |
I think it would be good to version the file format. I found some previous discussion about this in #131 (comment)
which seems fair, but in the unfortunate case that the format has to change, it would be good to have the format recorded in the file. Pluto would just check that opened files has a format it understand, or error out, instead of adding conversion code.
The text was updated successfully, but these errors were encountered: