Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@which macro shows local path but click through link is broken #451

Closed
waltsims opened this issue Sep 18, 2020 · 8 comments
Closed

@which macro shows local path but click through link is broken #451

waltsims opened this issue Sep 18, 2020 · 8 comments

Comments

@waltsims
Copy link

I was playing with the @which macro, which returns the local path of the function in pluto.jl but the click through link forwards to a broken github link.

e.g.

(::Type{LinearAlgebra.Diagonal})(A::AbstractArray{T,2} where T) in LinearAlgebra at /{local_path}/julia/usr/share/julia/stdlib/v1.5/LinearAlgebra/src/diagonal.jl:36


@which Diagonal([1 2 3])

but the clickthough link forwards to: https://github.com/JuliaLang/julia/tree/96786e22ccabfdafd073122abb1fb69cea921e17//usr/share/julia/stdlib/v1.5/LinearAlgebra/src/diagonal.jl#L36 (a broken link)

@fonsp
Copy link
Owner

fonsp commented Sep 18, 2020

Is this not an issue with Julia?

@waltsims
Copy link
Author

At least for me, Julia in the commandline doesn't offer a hyper link and the path given is the local source file. In pluto, there is a hyperlink.

@waltsims
Copy link
Author

Alright, I just cross-checked in IJulia and the same happens there. Must be a mistake with Julia. My mistake.

@fonsp
Copy link
Owner

fonsp commented Sep 20, 2020

This used to work at some point, at least for methods(Base.sqrt)

@dralletje
Copy link
Collaborator

dralletje commented Sep 20, 2020

It does work for some functions - from Base for example

@fonsp
Copy link
Owner

fonsp commented Sep 20, 2020

Maybe it works for Base, but not for the standard libraries?

@waltsims
Copy link
Author

That specification isn't made in the docs.

I think we can close this here at any rate. I will reopen in the Julia repo.

@fonsp
Copy link
Owner

fonsp commented Sep 21, 2020

Okay,

repr(MIME"text/html"(), @which Diagonal([1 2 3]))

should reproduce the bug in the REPL/in a script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants