-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening Github /raw links doesn't work #492
Comments
What is a |
/blob https://github.com/fonsp/Pluto.jl/blob/master/sample/Basic.jl I'm referring the normal Github interface webpage as a /blob link, and the raw file as a /raw link. A /raw link redirects to https://raw.githubusercontent.com. Sorry if my wording/naming is confusing. |
|
That's what I and I think presumably @zmoon thought, too. And I started changing the links in the 18S191 website to sent a pull request and before sending one I tried and I saw that Pluto doesn't work the way I thought it would. Here is how Pluto handles https://github.com/fonsp/Pluto.jl/raw/master/sample/Basic.jl . 1- It detects that this is a github.com link Then Pluto tries to open https://raw.githubusercontent.com/fonsp/Pluto.jl/raw/master/sample/Basic.jl but Github returns 404 error because this is an invalid link. The correct link is at https://raw.githubusercontent.com/fonsp/Pluto.jl/master/sample/Basic.jl, notice the /raw part missing. Pluto.jl/frontend/components/Welcome.js Lines 55 to 58 in df1fc95
|
Hi! I was working on this issue on the 18S191 repository and I realized that the links in the form of github.com / author / repo / raw / ..... , doesn't open.
I believe the problem can be solved by removing the "/raw" part from the URL path similar to what Pluto already does to /blob links.
Pluto.jl/frontend/components/Welcome.js
Lines 55 to 58 in df1fc95
The text was updated successfully, but these errors were encountered: