Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluto doesn't load if firebase did not initialize #583

Closed
fonsp opened this issue Oct 17, 2020 · 3 comments
Closed

Pluto doesn't load if firebase did not initialize #583

fonsp opened this issue Oct 17, 2020 · 3 comments
Assignees

Comments

@fonsp
Copy link
Owner

fonsp commented Oct 17, 2020

Also if the firebase CDNs are blocked by google-sceptic browser extensions.

I think this is why we are still getting reports that Pluto does not work offline

@pankgeorg
Copy link
Collaborator

pankgeorg commented Oct 19, 2020

There is a significant list of assets loaded via CDN (grep -R "jsdelivr" plus firebase) - how could Pluto work offline like that?

Regarding the firebase, I could compile a PR that just disables the feedback button if firebase did not load.
Update: I can't reproduce app crashing if firebase did not initialize (unless you click on the feedback button)

Am I missing something?

@fonsp
Copy link
Owner Author

fonsp commented Oct 19, 2020

how could Pluto work offline like that

We use a service worker #241 (comment)

@fonsp
Copy link
Owner Author

fonsp commented Oct 19, 2020

I'll look at this myself

@fonsp fonsp self-assigned this Oct 19, 2020
@fonsp fonsp closed this as completed Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants