Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move function reactivity from definition to call #25

Closed
malyvsen opened this issue Mar 6, 2020 · 2 comments
Closed

Move function reactivity from definition to call #25

malyvsen opened this issue Mar 6, 2020 · 2 comments
Labels
enhancement New feature or request expression explorer Figuring out assignments and references in a cell reactivity The Pluto programming paradigm

Comments

@malyvsen
Copy link
Collaborator

malyvsen commented Mar 6, 2020

Currently, function definitions are considered dependent on the variables and functions that are referenced in them, and function calls are considered dependent on definitions.
This breaks when a() calls b(), and b() calls a() - even though this double recursion is not paradigmatically illegal.

We should instead consider function calls dependent on the variables and functions referenced in the function definition. This will also solve the problem of reactivity in response to modifying global variables within functions.
@malyvsen malyvsen added enhancement New feature or request reactivity The Pluto programming paradigm expression explorer Figuring out assignments and references in a cell labels Mar 6, 2020
@fonsp fonsp mentioned this issue Mar 28, 2020
Merged
@fonsp
Copy link
Owner

fonsp commented Mar 28, 2020

This is now a testset 🐶

@fonsp fonsp closed this as completed Mar 28, 2020
@fonsp fonsp mentioned this issue Apr 5, 2020
Closed
@fonsp
Copy link
Owner

fonsp commented Aug 19, 2020

(This is reverted again, we have a separate fix for the two-function recursion)

@Hofsmo Hofsmo mentioned this issue Mar 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request expression explorer Figuring out assignments and references in a cell reactivity The Pluto programming paradigm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malyvsen @fonsp