Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Improvements to the handling of upstream git repos at the worker container #1228

Closed
2 tasks
felipesanches opened this issue Feb 10, 2017 · 3 comments
Closed
2 tasks
Assignees
Labels

Comments

@felipesanches
Copy link
Collaborator

felipesanches commented Feb 10, 2017

"gather from git" runs on the cmd-line specified TTF files once per commit.

Current shortcomings:

  • A) It does not cover more than one family stored in a single repo.

  • B) It does not follow git renames (I considered implementing that. It would be neat. But I did not think it was the most important thing to do in terms of priorities)

@davelab6
Copy link
Contributor

Given a git repo URL, git commit hash id, a fontbakery version are recorded in a central database of burndown results, it seems that we can have the gather tool cache it's findings and return early if it finds an existing result for the given repo hash with a version more up to date or equal to current version

@felipesanches
Copy link
Collaborator Author

Sounds great!

@felipesanches felipesanches changed the title Improvements to fontbakery_gather_burndown_data_from_git.py Dashboard: Improvements to the handling of upstream git repos at the worker container Apr 28, 2017
@davelab6 davelab6 assigned graphicore and unassigned felipesanches May 8, 2017
@felipesanches
Copy link
Collaborator Author

Migrating to fontbakery-dashboard issue tracker per #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants