test_xml_from_binary[graphite/graphite_tests.ttf-{Glat,Silf}] fail on big endian machines

[mcepl]

See full build log on ppc64 machine. I can see:

[   97s] =================================== FAILURES ===================================
[   97s] ____________ test_xml_from_binary[graphite/graphite_tests.ttf-Silf] ____________
[   97s] 
[   97s] testfile = 'graphite/graphite_tests.ttf', tableTag = 'Silf'
[   97s] 
[   97s]     def test_xml_from_binary(testfile, tableTag):
[   97s]         """Check XML from decompiled object."""
[   97s]         _skip_if_requirement_missing(testfile)
[   97s]     
[   97s]         xml_expected = read_expected_ttx(testfile, tableTag)
[   97s]     
[   97s]         with open_font(testfile) as font:
[   97s]             xml_from_binary = dump_ttx(font, tableTag)
[   97s]     
[   97s] >       assert xml_expected == xml_from_binary
[   97s] E       assert '<?xml versio...>\n\n</ttFont>\n' == '<?xml version...>\n\n</ttFont>\n'
[   97s] E         Skipping 1899 identical leading characters in diff, use -v to show
[   97s] E         - ow _i="0">1 1 2</row>
[   97s] E         ?            ---
[   97s] E         + ow _i="0">256 256 512</row>
[   97s] E         ?           +++++++++
[   97s] E         -             <row _i="1">0 3 0</row>
[   97s] E         ?                           ^...
[   97s] E         
[   97s] E         ...Full output truncated (63 lines hidden), use '-vv' to show
[   97s] 
[   97s] Tests/ttLib/tables/tables_test.py:297: AssertionError
[   97s] ____________ test_xml_from_binary[graphite/graphite_tests.ttf-Glat] ____________
[   97s] 
[   97s] testfile = 'graphite/graphite_tests.ttf', tableTag = 'Glat'
[   97s] 
[   97s]     def test_xml_from_binary(testfile, tableTag):
[   97s]         """Check XML from decompiled object."""
[   97s]         _skip_if_requirement_missing(testfile)
[   97s]     
[   97s]         xml_expected = read_expected_ttx(testfile, tableTag)
[   97s]     
[   97s]         with open_font(testfile) as font:
[   97s]             xml_from_binary = dump_ttx(font, tableTag)
[   97s]     
[   97s] >       assert xml_expected == xml_from_binary
[   97s] E       assert '<?xml versio...>\n\n</ttFont>\n' == '<?xml version...>\n\n</ttFont>\n'
[   97s] E         Skipping 161 identical leading characters in diff, use -v to show
[   97s] E           def">
[   97s] E         -       <attribute index="1" value="3"/>
[   97s] E         -       <attribute index="2" value="30"/>
[   97s] E               </glyph>
[   97s] E               <glyph name="space">
[   97s] E         -       <attribute index="1" value="3"/>...
[   97s] E         
[   97s] E         ...Full output truncated (19 lines hidden), use '-vv' to show
[   97s] 
[   97s] Tests/ttLib/tables/tables_test.py:297: AssertionError

The same error happens both with python 2.7.15 and with python 3.6.5

[anthrotype]

is that PowerPC? Interesting.. we don't run tests on that platform.
How can I reproduce this on my local (Debian Linux) machine?

[mcepl]

no idea. I am OpenSUSE Python packager, so I get this when building the package on ppc64 machine (see https://build.opensuse.org/package/show/home:mcepl:branches:M17N/python-FontTools although here the bug is already patched against). I can even add s390 machine, but I don't think it is necessary, ppc64 should be enough. Of course, everybody can get OBS account, and yes, it builds even for Debian. https://en.opensuse.org/openSUSE:Build_Service_Debian_builds

Doesn't Debian build farm has ppc64 and s390x machines? At least they seem to be available on https://packages.debian.org/sid/python-numpy …

[anthrotype]

Thanks @behdad!

[mcepl]

@behdad perfect, works, except for missing import sys in Lib/fontTools/ttLib/tables/G__l_o_c.py

[anthrotype]

@mcepl I fixed that on master. I will cut a new release before the end of this week.