Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can it be possible to replace problematic word master from this project code? #2896

Open
pnemade opened this issue Nov 18, 2022 · 3 comments

Comments

@pnemade
Copy link
Contributor

pnemade commented Nov 18, 2022

When I searched for "master" word, I found many entries that matched master and masters word/variable references in source code. I also saw same reference in https://github.com/fonttools/fonttools/tree/main/Doc/source/designspaceLib files.

Can upstream think if it can be replaced by some other alternative word?

@anthrotype
Copy link
Member

thanks for the reminder. Can you make a PR?

for branch name, "master" -> "main"

for designspace "master" -> "source"

@behdad
Copy link
Member

behdad commented Nov 18, 2022

Changing it in varLib would be harder / I don't think possible at this point.

@behdad
Copy link
Member

behdad commented Apr 19, 2023

Changing it in varLib would be harder / I don't think possible at this point.

Same about designspaceLib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants