Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to add fonts #5

Closed
acauamontiel opened this issue Mar 31, 2016 · 1 comment
Closed

Command to add fonts #5

acauamontiel opened this issue Mar 31, 2016 · 1 comment
Assignees
Milestone

Comments

@acauamontiel
Copy link

Sometimes you need to add custom or paid fonts in your project.

Would be nice if there was a command like fontwr add {{fontname}}, where {{fontname}} is the path to the font folder.

Obviously the added fonts should be placed into the system's font directory.

@raphaklaus raphaklaus added this to the 1.0.0-beta3 milestone Mar 31, 2016
@raphaklaus
Copy link
Member

Thanks for the suggestion, I've added this case into #6!

Digging in, {{fontname}} could be a directory or a single file.

If {{filename}} is a directory, then: fetch all .ttf files, place them inside tmp/ and pipe them into CLI conversion method so user can choose what format and in the end generate font-face.

if {{filename}} is a single file, then: fetch it, place inside tmp/ and pipe it into CLI conversion method so user can choose what format and in the end generate font-face.

I don't know if place into system's font directory is the best approach, since it's job of -g.
My concern is how fontwr install will behave with external added fonts...

Any PR is welcome, but I recommend try after 1.0.0-beta.2

@raphaklaus raphaklaus modified the milestones: 1.0.0-beta3, 1.0.0-beta.3 Mar 31, 2016
@raphaklaus raphaklaus self-assigned this May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants