Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Cannot disable Apple Points #867

Open
max-kubierschky opened this issue Apr 21, 2021 · 5 comments
Open

bug: Cannot disable Apple Points #867

max-kubierschky opened this issue Apr 21, 2021 · 5 comments
Labels
Milestone

Comments

@max-kubierschky
Copy link

We do not (yet) need Apple Points yet and I want to disable them.
There is a checkbox "Apple points" on Administration -> Tasks. When I uncheck it and press Save, I am redirected to page Administration -> Foodcoop. When I navigate back to page Administration -> Tasks, the checkbox is checked again and Apple points are apparently active.

@max-kubierschky max-kubierschky changed the title Cannot disable Apple Points bug: Cannot disable Apple Points Apr 21, 2021
@max-kubierschky
Copy link
Author

max-kubierschky commented Apr 30, 2021

I found out now, that I can disable Apple Points by setting use_apple_points: false in config/app_config.yml. So it is ok for me now. I leave this bug open, for it is a bug anyway.
For reference: I am on v4.7.1

@mjavurek mjavurek added the bug label Oct 7, 2021
@wvengen
Copy link
Member

wvengen commented Feb 9, 2022

Thanks for the bug report. This is indeed an issue. Some suggested the issue may reside with rails-settings-cached (we're using a really old version, but the feature we use isn't supported in later versions - perhaps for a reason).

Possible ideas to fix this to replace rails-settings-cached with:

  • Load all configuration variables on each request.
  • Keep a cache of all variables for all foodcoops across requests, using redis to communicate that a reload is needed for a certain foodcoop. Here the memory scales with the number of foodcoops, but it shouldn't be too bad. Can use a LRU approach to keep memory in check.
  • Find a gem that does something like the previous.

But first we might want to verify that the issue resides with rails-settings-cached indeed.

@wvengen
Copy link
Member

wvengen commented Feb 9, 2022

n.b. this issue has been reported occasionally in the past years.

@decentral1se
Copy link
Member

Just wanted to chime in and say that I ran into this a few times. For some reason my config keeps reverting when a deployment fails and then the use_apple_points: false is commented out and therefore it is enabled (despite not being selected in the admin settings).

@yksflip
Copy link
Member

yksflip commented Oct 19, 2023

probably the same issue in #820

@yksflip yksflip added this to the 4.8.2 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Prioritised
Development

No branches or pull requests

5 participants