Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_color has inconsistent return type #34

Closed
ixtli opened this issue Aug 20, 2014 · 4 comments
Closed

make_color has inconsistent return type #34

ixtli opened this issue Aug 20, 2014 · 4 comments

Comments

@ixtli
Copy link

ixtli commented Aug 20, 2014

https://github.com/Fooidge/PleaseJS/blob/master/Please.js#L551

I'm curious why this returns the color as a string if there's only one result, but an array otherwise. Makes embedding code sort of convoluted. I didn't submit a patch because I assume there's a reason, but I just wanted to know what it is.

@NadyaNayme
Copy link

Duplicate of: #26

Looks like the change never happened?

@Fooidge
Copy link
Owner

Fooidge commented Aug 21, 2014

Haven't had time. Have a new job. I'm aware of the issue and will fix it.

Super duper promise.

Jordan Checkman

On Aug 20, 2014, at 6:50 PM, Kyokou notifications@github.com wrote:

#26

I thought this was changed already?


Reply to this email directly or view it on GitHub.

@ixtli
Copy link
Author

ixtli commented Aug 21, 2014

Haha no rush! It's just that we tried using it at our job and were frustrated so we took immediately to the internet to complain!

@Fooidge
Copy link
Owner

Fooidge commented Sep 16, 2014

Fixed!

@Fooidge Fooidge closed this as completed Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants