Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black, Grays return red shades #38

Closed
donnieberg opened this issue Sep 30, 2014 · 4 comments
Closed

Black, Grays return red shades #38

donnieberg opened this issue Sep 30, 2014 · 4 comments

Comments

@donnieberg
Copy link

I'm not sure if this is just me, but I tested Please.make_color with base_color gray and black, and it always returns red shades. I'm fairly new at coding so please let me know if it's me being a n00b :)

var colors = Please.make_color({
base_color: 'gray',
colors_returned: 20,
format:'hex'
});

@Fooidge
Copy link
Owner

Fooidge commented Sep 30, 2014

I'll look into it. There's a small bug wherein colors that translate to hue: 0 can come out as red. Might be that.

Jordan Checkman

On Sep 30, 2014, at 1:58 PM, donnieberg notifications@github.com wrote:

I'm not sure if this is just me, but I tested Please.make_color with base_color gray and black, and it always returns red shades. I'm fairly new at coding so please let me know if it's me being a n00b :)

var colors = Please.make_color({
base_color: 'gray',
colors_returned: 20,
format:'hex'
});


Reply to this email directly or view it on GitHub.

@donnieberg
Copy link
Author

awesome! Thank you so much for looking into it.

@Fooidge
Copy link
Owner

Fooidge commented Oct 24, 2014

Latest update addresses this. Sorry for the wait :)

@Fooidge Fooidge closed this as completed Oct 24, 2014
@donnieberg
Copy link
Author

Awesome!! Thanks so much for fixing that :)

On Fri Oct 24 2014 at 4:31:00 PM Jordan Checkman notifications@github.com
wrote:

Closed #38 #38.


Reply to this email directly or view it on GitHub
#38 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants