-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot request GraalVM packages with filtering on jdk_version
#66
Comments
Weirdly following also works, though I wouldn't expect it, if the problem is with |
Hmm...so a bit of history here first, originally the disco api was made for builds of openjdk only but then we also added builds of graalvm which came with their own versioning which is different from openjdk. For that reason the jdk_version field was added. So the problem with graalvm is that you can get the same version e.g. 22.3 based on different jdk's, in this case for example on jdk 17 and jdk 19. That is also the reason why we add every graalvm version based on their jdk at the moment. This might change in the future where there might only be graalvm with a java version of 22.3 and a jdk version of 17 for example. But for the moment it is what it is. So it's expected that if you ask for graalvm_ce11 and jdk_version 11 you should get the right pkgs, it's not ok that if you ask for graalvm_ce16 and jdk_version 16 you get an empty response...there should be pkgs. Usually to get the latest version you would ask for distribution=graalvm_ce16 and latest=available. So I will look into this right now...thx for the heads up 👍🏻 |
Ok, thanks. I'm looking for the latest version for a certain language/jdk level. |
Found the issue and already fixed it, the deployment is on it's way, so expect it to work within the next 2 hours. Will post here as soon as it will be in production. |
Appreciated! |
The deployment is done so it should now work as expected...fingers crossed :) |
Looks like it does, thank you! |
Good to know, thanks for testing 👍🏻 |
Works:
https://api.foojay.io/disco/v3.0/packages?distro=graalvm_ce16
Doesn't:
https://api.foojay.io/disco/v3.0/packages?distro=graalvm_ce16&jdk_version=16
Also works (sanity check):
https://api.foojay.io/disco/v3.0/packages?distro=temurin&jdk_version=16
The text was updated successfully, but these errors were encountered: