Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Unqualified "TODO" code comment #2805

Closed
jugglinmike opened this issue May 17, 2023 · 2 comments
Closed

Unqualified "TODO" code comment #2805

jugglinmike opened this issue May 17, 2023 · 2 comments

Comments

@jugglinmike
Copy link
Contributor

The update-bcd.ts script has eight "TODO"-style code comments, but one of them omits an explanation of the task which motivated it:

lastWasNull = false;
} else if (supported === null) {
lastWasNull = true;
// TODO
} else {
throw new Error(`result not true/false/null; got ${supported}`);

The comment introduced in 2020 via commit d5ff5fe. Its position implies that something more ought to be done when encountering a browser version with no support information, but I haven't been able to infer what that is.

I've been gathering together a list of enhancements for that script, and I don't want to miss whatever functionality motivated that comment.

@foolip
Copy link
Owner

foolip commented May 18, 2023

@queengooborg can you speak to this?

@foolip
Copy link
Owner

foolip commented Sep 26, 2023

Closing this issue to tombstone this repo. @jugglinmike since the update script has now moved to BCD in mdn/browser-compat-data#19971, can you refile the issue on BCD if you feel it is still relevant?

@foolip foolip closed this as completed Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants