Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplecert.Init should maybe init with previous certificate when renew fails on init #24

Closed
azukaar opened this issue Apr 9, 2023 · 3 comments

Comments

@azukaar
Copy link
Contributor

azukaar commented Apr 9, 2023

This is an extension to #14 that was fixed earlier:
Here's a scenario:

  • I have a working certificate with 3 domains including the main domain for the administration
  • I add an additional domain from the administration, and restart the server
  • SimpleCert will try to replace the certificate with the 4th domain
  • The 4th domain is invalid, so It will fail to init, the admin panel won't be accessible anymore to fix the 4th domain

How I could see this could works, is for example having a setting "fallbackToPreviousCert" that would do exactly what it suggest when failing to review on init? What do you think?

@dreadl0ck
Copy link
Contributor

Thanks for reporting, will look into this soon.

@dreadl0ck
Copy link
Contributor

Fixed in https://github.com/foomo/simplecert/releases/tag/v1.8.6

Let me know if there are any issues.

@azukaar
Copy link
Contributor Author

azukaar commented May 9, 2023

Amazing will test, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants