Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show player count as activity #16

Merged
merged 5 commits into from Nov 8, 2022
Merged

Show player count as activity #16

merged 5 commits into from Nov 8, 2022

Conversation

voruti
Copy link
Contributor

@voruti voruti commented Nov 7, 2022

This PR adds:

Showing the current amount of players connected to the proxy as Discord activity. The text/amount gets updated in method updateActivityPlayerAmount() which will be called when the bot is "ready" (initialize) or a player joined or left the game (regular updates). The activity text is configurable in the config.

Screenshot:

activity
("Spielt" is "is playing" - Discord uses localized texts & my Discord client is setup with the German language.)

@voruti
Copy link
Contributor Author

voruti commented Nov 7, 2022

I thought about implementing a toggle in the config to be able to disable this feature - is this even necessary?

@fooooooooooooooo
Copy link
Owner

i like having things as configurable as possible, so a config option would be nice to have

@fooooooooooooooo
Copy link
Owner

thanks for the pr :)

@fooooooooooooooo fooooooooooooooo merged commit 83f89fa into fooooooooooooooo:master Nov 8, 2022
@voruti voruti deleted the player-count-activity branch November 8, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants