Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issue with blank lines #13

Closed
foprel opened this issue Dec 16, 2021 · 1 comment
Closed

Resolve issue with blank lines #13

foprel opened this issue Dec 16, 2021 · 1 comment

Comments

@foprel
Copy link
Owner

foprel commented Dec 16, 2021

Latest PR to implement skipping of blank lines caused unexpected and unstable behaviour. The __next__() method of the DictReader class needs to be restructured to skip blank lines. Possibly give users the options to determine whether to skip blank lines or not by adding a kwarg to the constructor.
@foprel
Copy link
Owner Author

foprel commented Jan 23, 2022

Resolved with PR #15. Users are now able to pass the booleanskip_blank_lines argument into the constructor.

@foprel foprel closed this as completed Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@foprel