Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add count reservations functionality #43

Merged
merged 2 commits into from Jul 28, 2022
Merged

Add count reservations functionality #43

merged 2 commits into from Jul 28, 2022

Conversation

AbrahaKahsay
Copy link
Collaborator

Project description

  • Even if the API gives you the number of reservations you will create a specific function to calculate it.
  • Make sure that the correct number is displayed on the Reservations pop up.

@AbrahaKahsay AbrahaKahsay linked an issue Jul 28, 2022 that may be closed by this pull request
[3pt] - Add reservations counter - Student C #4
Closed
@for-ashraf for-ashraf self-requested a review July 28, 2022 22:51
for-ashraf
for-ashraf approved these changes Jul 28, 2022
View reviewed changes
Copy link
Owner

@for-ashraf for-ashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 💯

Hi, @abraha Congratulations your project is complete. there is nothing to say except go and merge it.

To highlight

  • Met all requirements ✔️
  • No linter errors ✔️
  • Followed best practices for Javascript ✔️

@AbrahaKahsay AbrahaKahsay merged commit 3bd4703 into development Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@for-ashraf for-ashraf for-ashraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3pt] - Add reservations counter - Student C
2 participants
@AbrahaKahsay @for-ashraf