JavaScript capstone project - Your API-based webapp #46
Conversation
Webpack installed
Output Management and Jest Testing has been implemented.
Movie logo has been updated
Header footer layout
Display of data from the API has been incorporated
Display of API data has been implemented
…n-the-homepage-student-a 15 4pt display list of items on the homepage student a
…p-task FInd an external api for implementation
Add header and style
…th-selected-items-details-student-c
…p-up-with-selected-items-details-student-c Add reservation controller
…r-a-given-item-on-the-reservations-pop-up-student-c Update reservation controller
…eservation-student-c Update reservation controller
…-student-c Add count reservations functionality
…ns-counter-student-c 1 3pt add tests for reservations counter student c
There was a problem hiding this comment.
Hi @Team,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!
To Highlight 💯
- No linter error ✔️
- Website looks ok 👍
Required changes
Check the comments under the review.
Optional changes
You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
| this.likesControllers.getLikes().then((res) => { | ||
| const obj = res.find((o) => o.item_id === movie.id); | ||
| if (obj != null) { | ||
| const likeCount = document.getElementById(`likes${movie.id}_count`); | ||
| const [, keep] = likeCount.innerHTML.split(' '); | ||
|
|
||
| const intVal = parseInt(obj.likes, 10); | ||
| likeCount.innerHTML = `${intVal} ${keep}`; | ||
| } | ||
| }).catch((err) => err); | ||
|
|
||
| document.getElementById('cardHolder').appendChild(divHolder); | ||
| this.countShows(); | ||
| const likeLiterner = document.getElementById(`likes${movie.id}`); | ||
| if (likeLiterner) { | ||
| likeLiterner.addEventListener('click', () => { | ||
| this.sendLikes(movie.id, `likes${movie.id}`); | ||
| }); | ||
| } |
There was a problem hiding this comment.
- When I like any movie, the counter is increasing at that moment, but when the page is refreshed
likesgo back to the initial one. Please fix this.
README.md
Outdated
|
|
||
| - Run "npm start" command at terminal to browse the page. | ||
| ## Loom Video Link for a brief intro of the app | ||
|
|
||
| - https://www.loom.com/share/873c948d2210470780a12d503a22e857 | ||
|
|
There was a problem hiding this comment.
- In the video presentation, Please show up all the members and talk about the project.
README.md
Outdated
|
|
||
| - Clone the github repository and set up linters and webpack | ||
|
|
There was a problem hiding this comment.
- I would also recommend writing the proper steps to clone and run the project locally.
HInt:
$ git clone yourrepo.git
$ cd yourrepo
$ npm i
$ npm start
$ npm test # for testing
There was a problem hiding this comment.
Hi team,
APPROVED 🟢
Highlights
✔️ Data is stored on the API
✔️ Good styling
✔️ Descriptive PR
Great implementation of all the requirements in this milestone. 👏
You have done an amazing job 👍
Your project is complete! There is nothing else to say other than... it's time to merge it. 
Congratulations! 🎉
CHEERS AND HAPPY CODING!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this PR, I have implemented the following:
- Used JavaScript to make websites dynamic and build basic single page apps.
- Used ES6 syntax.
- Used ES6 modules.
- Used callbacks and promises.
- Used webpack.
- Applied JavaScript best practices and language style guides in code.
- Used AAA pattern for unit tests.
- Write units tests for a JavaScript app.
- Followed Gitflow.
- Solved simple git conflicts.
- Send and receive data from an API.
- Used API documentation.
- Used JSON.
- Make JavaScript code synchronous.
- Perform a code review for a team member.
Implementation