Skip to content
This repository has been archived by the owner on Dec 6, 2018. It is now read-only.

Clarified platform definitions #89

Merged
merged 5 commits into from Jun 18, 2016
Merged

Clarified platform definitions #89

merged 5 commits into from Jun 18, 2016

Conversation

forGGe
Copy link
Collaborator

@forGGe forGGe commented Jun 15, 2016

/cc @vadimol

Issue: #50

vadimol
vadimol reviewed Jun 16, 2016
View reviewed changes
platform/stm32f4xx/export/aux/pin_descriptor.hpp

// Pin purpose
enum class function
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a task for removing this? we can use SPL definitions in platform code.

Copy link
Collaborator Author

@forGGe forGGe Jun 16, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be covered within #84
Wrappers can be made a lot thinner than current implementation, providing similar to SPL functionality.

@vadimol
Copy link
Collaborator

vadimol commented Jun 16, 2016

Please, open a task for removing GPIO module. We can use SPL directly in platform.
Overall it looks fine for now, but we need to discuss the common module

@forGGe
Copy link
Collaborator Author

forGGe commented Jun 16, 2016

#84 is created for that purpose. Reason to provide (may be) lighter wrappers is that it can check twisted pin usage and protect integer GPIO parameters from mixing with each other using enum classes.

If you don't mind, in the scope of this PR, I'll remove common gpio module as well as pin_descriptor.hpp

@forGGe
Moved common pin into the platform descriptor module
1d85944 
1st step of removing it completely.
@forGGe
Get rid of 'register_project' cmake call
21bd688 
It is redundant at this moment and should be removed
@vadimol
Copy link
Collaborator

vadimol commented Jun 18, 2016

Looks good for me

@forGGe forGGe merged commit 21bd688 into develop Jun 18, 2016
forGGe added a commit that referenced this pull request Jun 18, 2016
@forGGe
Merge pull request #89 from forGGe/platform_defs
ecc1a77 
Clarified platform definitions
@forGGe forGGe deleted the platform_defs branch June 18, 2016 15:20
@forGGe forGGe mentioned this pull request Jun 18, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@forGGe @vadimol