Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sdkmath type in PoolSnapshot #536

Merged
merged 5 commits into from
Mar 17, 2023
Merged

fix: sdkmath type in PoolSnapshot #536

merged 5 commits into from
Mar 17, 2023

Conversation

saiSunkari19
Copy link
Contributor

Description

Closes: #XXXX

typo fixes

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@MonikaCat
Copy link
Contributor

MonikaCat commented Mar 10, 2023 •
edited

Hey @saiSunkari19 can you also update go version to 1.18 to fix unit tests and include entry inside CHANGELOG.md? Thanks!

@saiSunkari19
Copy link
Contributor Author

saiSunkari19 commented Mar 10, 2023 •
edited

Sure, I will do that, but current upstream branch is with 1.19. Do you want me to update that

@MonikaCat
Copy link
Contributor

Hi @saiSunkari19 yes please, thanks!

MonikaCat
MonikaCat reviewed Mar 17, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Mar 17, 2023
@MonikaCat
Copy link
Contributor

Hey @saiSunkari19 can you update go version to 1.18 on this line please? Thanks 👍🏻

@saiSunkari19
Copy link
Contributor Author

Updated, Thanks

@mergify mergify bot merged commit 4e03eaa into forbole:cosmos/v0.46.x Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

@MonikaCat MonikaCat MonikaCat approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saiSunkari19 @MonikaCat @RiccardoM